Re: [Jack-Devel] [jack2] Add JackPortIsCV flag (#34)

PrevNext  Index
DateSat, 11 May 2013 10:46:14 +0200
From Stéphane Letz <[hidden] at grame dot fr>
Tojackaudio/jack2 <[hidden] at reply dot github dot com>
Cc"[hidden] at lists dot jackaudio dot org devel" <[hidden] at lists dot jackaudio dot org>
Follow-UpPaul Davis Re: [Jack-Devel] [jack2] Add JackPortIsCV flag (#34) 
Le 11 mai 2013 ࠰2:05, falkTX <[hidden]> a 飲it :

> This pull request adds a new JACK port flag, JackPortIsCV.
> 
> This is useful for applications that use JACK audio ports as CV.
> As it's merely a hint, it won't hurt current JACK usage.
> Patch-bays will welcome this change and may choose to represent these ports in a special way.
> 
> A new macro was also added, JACK_HAS_PORT_IS_CV_FLAG.
> This allows new applications to safely check for this new flag existence.
> 
> You can merge this Pull Request by running
> 
>   git pull https://github.com/falkTX/jack2 master
> Or view, comment on, or merge it at:
> 
>   https://github.com/jackaudio/jack2/pull/34
> 
> Commit Summary
> 
> 	• Add JackPortIsCV flag
> 	• Add JACK_HAS_PORT_IS_CV_FLAG macro
> File Changes
> 
> 	• M common/jack/types.h (11)
> Patch Links:
> 
> 	• https://github.com/jackaudio/jack2/pull/34.patch
> 	• https://github.com/jackaudio/jack2/pull/34.diff

Then I would suggest:

- make the name more explicit : JackPortIsCV  ==> JackPortIsControlVoltage

- seems that JackPortIsControlVoltage value should be 0x20 

What do other JACK core developers think about this proposal?

Thanks.

St鰨ane
PrevNext  Index

1368261991.9377_0.ltw:2, <C3B13EF2-F182-4CA1-AEA4-951188E3ABE4 at grame dot fr>