Re: [Jack-Devel] Cleanup of clients in libjack2 causes crash

On 16-04-13 23:27, Stéphane Letz wrote:
>>>
>> The example code I wrote, such a change would be trivial.
> Trivial changes are not always good. Especially if they are done to mask badly designed code...
>
>> However, I'm allocating jack clients from two threads,
> Why that?
>
>> so now I have to put locks around every libjack call,
> libjack API is *not* multi-threads aware in general.
>
>
>> check if any jack client has gotten a shutdown message, or if jack_client_open returns NULL in case jackd decides to exit while I'm in the middle of allocating clients.
> jackd does not "decide" to exit…  But jackd may have a bug that could cause a crash. Then this bug should be fixed. Is that what you see?
>
>> Then I would have to make sure that all jack clients are deallocated before attempting to make new clients.
> Maybe you should simplify your code yes?
>
>> I would also have to check if my program is using libjack1 or libjack2, since libjack1 does not do this.
>>
>> All this so that programs can save maybe a kilobyte of ram when not following the API correctly.
>>
>> Bob.
>>
> Yep exactly… your specific needs are not so common.
>
> Stéphane
>
>
Thanks for your time, I will not discuss this any futher.

Bob.

1366148740.16956_0.ltw:2,a <516DC679.1010104 at gmail dot com>