Re: [Jack-Devel] jack2 on ARM - patch]

On Wed, Jan 02, 2013 at 11:23:18AM +0100, Robin Gareus wrote:
> > Then Robin it would be great to look at this code and possibly test
> > (= merge or rebase) it with latest git head and see if it works.
> 
> Basil's work can be rebased without any conflicts onto the current HEAD.
> It needs some minor modifications (JackNetTool.h) to compile:
>   https://github.com/x42/jack2/commits/nopackedstructs
> and then works as promised - tested on arm and i386.

Hi Robin, Thanks for rebasing my patches and testing them! I apologize
for not responding sooner :-(.

In case it's useful, I've now rebased my tree and properly incorporated
the JackNetTool.h fixes:

https://github.com/basilnut/jack2.git

Feel free to use this updated tree, or not; it's not important to me
which path the patches take :-).

> Interestingly enough, the ABI changes do not seem to make a difference
> on i386 nor on armel. (basil's jackd2 was configured with --classic
> --alsa --dbus --firewire).

The ABI changes I called out are pretty obscure. To the best of my
knowledge, none of jack2's own type layouts changed. The main concern
would be if users of the API have jack2 types as members of their own
structs, and even then, there's a decent chance that they'll get "lucky"
and not see any change.

> On i386: Ardour3, xjadeo, zita-a2j (all compiled with jack2-1.9.9) as
> well as baudline continue to work just fine with initial tests. On arm I
> only tested some commandline tools jack_capture, jltcgen. No problems
> either, so far.

Great! Thanks for the testing!

Basil

1364946425.21913_0.ltw:2,a <20130402234658.GB6607 at li95-58 dot members dot linode dot com>