Re: [Jack-Devel] jack2 on ARM - patch

Robin Gareus <[hidden]> writes:

> On 01/01/2013 11:20 PM, Stéphane Letz wrote:
>> And there was Basil Nutmeg proposal in july 2012 that was finally prepared on a git branch here:
>> 
>> https://github.com/basilnut/jack2/
>
> As documented in the git log messages, it breaks the ABI. AFAIK that is
> a no-go.
>
> ---
> Quotes from the commit log:
>
> In the current tree, with packed attributes on the relevant structs,
> the only impact of this change is that the alignments of jack_unique_t
> and jack_time_t are increased from 4 to 8 on 32-bit platforms, so
> the layouts of structs which include them as members may be affected.
>
> The ABI impact relative to the tree before the packed attributes
> were introduced is that the alignment of jack_position_t is increased
> from 4 to 8 on 32-bit platforms. The layout of the struct itself is
> unmodified, though the layouts of structs which include it as a
> member may be affected.
>
> jack_latency_range_t and jack_position_t are no longer packed. The
> layouts of these structs themselves are unmodified, though the layouts
> of any structs which include these structs as members may be affected.

The jack1/jack2 ABI breakage that happened because of the packed structs
is much more worrisome.

-- 
Nedko Arnaudov <GnuPG KeyID: 5D1B58ED>

1357128351.15208_0.ltw:2,RSa <87wqvvbxio.fsf at arnaudov dot name>