Re: [Jack-Devel] jack session fix (jack1)

Ok. so as I understood, already existing session directory is:

- Jack1 guys => ERROR

- Jack2 guys.. you support this, so are you think this is bug in your code ? I can provide patch if needed.

Will be great if this two implementation will be consistent.

Dnia 27-11-2012 o godz. 21:22 rev8 napisa³(a):
> Hi,
> 
> I see your point of view. SM for handling this case should create new 
> temporary directory and after successful save it can just replace this 
> previous session dir.
> 
> .. but , when some app have a lot of data in session dir then that is 
> waste of space. I think user should decide and take risk for such case. 
> At least qjackctl warns before use of existed directory, but after all 
> if user decide to try save then it allow that.
> 
> Situation is more complicated in QuitAndSave mode, because then some 
> clients may already be closed. That's way I think there should be just 
> Quit event type. If SM want QuitAndSave then it can do this in two steps 
> 'save' (check if not error) and quit.
> 
> Dnia 27-11-2012 o godz. 20:29 Torben Hohn napisa³(a):
> > On Tue, Nov 27, 2012 at 07:55:43PM +0100, rev8 wrote:
> > > Hi,
> > > 
> > > I create fix for Jack1 session support. This is the case when session
> > directory already exists (i.e. we just update our session). Jack2
> > handling this well.
> > > 
> > > I hope this time patch is in proper format ;-)
> > 
> > The case where the session directory already exists, is an Error.
> > If some client in the session  fails to save, and some other clients
> > saved over the session state, you end up with a broken session.
> > 
> > If a session manager triggers this condition, it should get fixed.
> > 
> > 
> > --
> > Mit freundlichen Grüßen
> > Torben Hohn
> > 
> > Linutronix GmbH
> > 
> > Standort: Bremen
> > 
> > Phone: +49 421 166 73 41 ; Fax.: +49 7556 919 886
> > mailto: [hidden]
> > Firmensitz / Registered Office: D-88690 Uhldingen, Auf dem Berg 3
> > Registergericht / Local District Court: Freiburg i. Br., HRB Nr. / Trade
> > register no.: 700 806;
> > 
> > Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner
> 
> Best Regards
> Xj
> 
> 
> 
> Jack-Devel mailing list
> [hidden]
> http://lists.jackaudio.org/listinfo.cgi/jack-devel-jackaudio.org

1356155484.19738_0.ltw:2,a <50d54a4e400fe1.20085158 at wp dot pl>