Re: [Jack-Devel] [LAU] jack2 turned verbose

On 06/05/2012 05:30 AM, Nedko Arnaudov wrote:
> Brendan Jones<[hidden]>  writes:
>
>>> http://lists.linuxaudio.org/listinfo/linux-audio-user
>>
>> I've had a closer look at this and this patch seems to be working for
>> me (their's no equivalent bool in jack_driver_param_value_t)
>>
>> diff -Nurp '-x*~' jack-1.9.8.orig/common/JackControlAPI.cpp
>> jack-1.9.8/common/JackControlAPI.cpp
>> --- jack-1.9.8.orig/common/JackControlAPI.cpp	2011-12-19
>> 12:54:02.000000000 +0100
>> +++ jack-1.9.8/common/JackControlAPI.cpp	2012-06-04 21:57:59.264581780 +0200
>> @@ -246,7 +246,7 @@ jackctl_add_driver_parameters(
>>               break;
>>           case JackDriverParamBool:
>>               jackctl_type = JackParamBool;
>> -            jackctl_value.b = descriptor_ptr->value.i;
>> +            jackctl_value.b = (descriptor_ptr->value.i>  0);
>>               break;
>>           default:
>>               jack_error("unknown driver parameter type %i",
>> (int)descriptor_ptr->type);
>
> Does "working for me" mean that verbose is not enabled by default anymore?

That's correct. A cast to bool (which is more appropriate) also seems to 
work. It also corrects the jackdbus SIGSEGV you listed earlier.

>
> The verbose parameter is not driver parameter, so it should not
> be affected by this code at all.

It seems that it is (adding at line 228: printf("Driver parameter: 
%s\n",descriptor_ptr->name) );

.
Driver parameter: output-latency
Driver parameter: inchannels
Driver parameter: outchannels
Driver parameter: verbose
Driver parameter: snoop
.
.
.

>
> My reading of the C++ standard is that the implicit conversion is
> valid. C++11, section 4.12 states:
>
> "A prvalue of arithmetic, unscoped enumeration, pointer, or pointer to
> member type can be converted to a prvalue of type bool. A zero value,
> null pointer value, or null member pointer value is converted to false;
> any other value is converted to true. A prvalue of type std::nullptr_t
> can be converted to a prvalue of type bool; the resulting value is
> false."
>
> Of course, explicit conversion is valid as well. I still claim that the
> generated code for jackctl_add_parameter() calls for "temporary" and
> "verbose" engine parameters is wrong because it pushes union
> jackctl_parameter_value with value of 10 (for both bool and integer
> members) while it should push false/0. both 1 and 10 are true, not
> false. the default value for both parameters is false.
>

Granted - but there is something in O/O2/O3 which is causing the union 
packing to go awry. I tried to create an isolated test case but failed.

1338869538.18103_0.ltw:2,a <4FCD8717.5030304 at gmail dot com>