Re: [Jack-Devel] Github pull requests

On Fri, Mar 02, 2012 at 12:34:02PM +0200, Nedko Arnaudov wrote:

> >>>> Now that Jack development is on Github, can patches be proposed via the
> >>>> Github pull-request feature, or should they still be posted on the ML ?
> >>>
> >>> for now i'd prefer to keep them on the ML.
> >>
> >> I think it would be nice to preserve authors of git commits.
> >
> > Both git pull and git am preserve authors.
> Unless the author is omitted in the submitted patch as it is the case
> with the ones in this thread..

Which means we're lacking documentation.

   http://www.alsa-project.org/main/index.php/GIT_Server#Occasional_Developers

is so good for the occasional developer.

For jack, it boils down to mention

   git-format-patch -n -s -p

and

   git-send-email

somewhere.

Alternatively, we should establish a workflow based on pull requests.


But the patches we just got are the worst possible way to do it. No
attribution to the author, no commit message, no automatic integration.

That said, part of the decision to host the repos at github was to
encourage contributions from others, so let's make sure to make the
submission process as convenient as possible for all of us.

If I was about to cast a vote, then it'd be

   [x] document the git send-email approach as ALSA did it
   [x] also use pull requests and maybe discuss the patches on the ML
       before merging


Cheers

-- 
mail: [hidden]  	http://adi.thur.de	PGP/GPG: key via keyserver

1330685494.11989_0.ltw:2,a <20120302105119.GS5534 at ltw dot loris dot tv>