Re: [Jack-Devel] jack1 version jack2 public headers comparison

Paul Davis <[hidden]> writes:

>> New :
>> =====
>>
>> void
>> jack_get_version(
>>    int *major_ptr,
>>    int *minor_ptr,
>>    int *micro_ptr,
>>    int *proto_ptr) JACK_OPTIONAL_WEAK_EXPORT;
>>
>>
>> const char *
>> jack_get_version_string() JACK_OPTIONAL_WEAK_EXPORT;
>>
>> ==> not really used? Should they be removed?
>
> i am opposed to any such API in JACK. providing version information
> like this encourages bad/stupid/unnecessary behaviour by developers.
> as the docs for automake describe, if you're interested in whether or
> not a particular feature exists in something you want to use, test for
> the *feature* not some arbitrary version number.

The second call is for reporting the jack version in the jackdbus log
file. jackd uses the internal macro VERSION instead.

jack_get_version_string() is also required for reporting jack server
version over dbus. I want this information to be present somewhere in
gladish (the GUI frontend bundled in the ladish tarball).

As for the first function I'm all for feature based tests but we
dont really have this in the API yet. jackdbus doesnt use nor exports
the major/minor/micro/proto data over dbus. At least not yet.

>> int jack_get_client_pid (const char *name) JACK_OPTIONAL_WEAK_EXPORT;
>
> needed for?

ladish L0 jack client to app mapping is built around this.

>> New :
>> =====
>>
>> jack_port_type_id_t jack_port_type_id (const jack_port_t *port) JACK_OPTIONAL_WEAK_EXPORT;
>
> needed for?
>
>> typedef uint32_t jack_port_type_id_t;
>
> use?

jackdbus uses it to report [integer] port types over dbus.

-- 
Nedko Arnaudov <GnuPG KeyID: 5D1B58ED>

1330439329.32034_0.ltw:2,a <878vjndof7.fsf at arnaudov dot name>