Re: [Jack-Devel] [PATCH JACK1 & JACK2] drivers/alsa/memops.c: Error when source is non-native byte-order float

Le 27 oct. 2011 à 14:15, Gabriel M. Beddingfield a écrit :

> 
> Hi Stéphane,
> 
> On 10/27/2011 03:29 AM, Stéphane Letz wrote:
>> Hi Gabriel,
>> 
>> I recently committed your patch (adapted to JACK2) hoping it would solve the issue one guy had here with a pure float audio card, but:
>> 
>> 1) it did not solve this specific issue
>> 
>> 2) it seems that the patch breaks ALSA driver with some cards: see http://trac.jackaudio.org/ticket/243
> 
> Hmmm... I didn't expect anyone to apply this patch without first saying something along the lines of "Gabe... you're doing it wrong."  After all, memops.c is really old and heavily-used code.
> 
>> Can you possibly check the patch I did at http://trac.jackaudio.org/changeset/4541 (maybe I did something wrong)
> 
> Well, I presume the user has an x86 (LE) machine.  They're using a USB Fast Track Pro... and I would expect for it to be LE as well. Meanwhile, this patch was trying to fix cases where the byte order was OPPOSITE the native byte-order.
> 
> Does anyone know for sure what the byte order of a Fast Track is?
> 
> -gabriel
> 


So should I revert it? Or can you provide a fix?

Thanks.

Stéphane 

1319723519.26094_0.ltw:2,a <113BF4F5-140A-4D13-B7FF-1AB1A3573427 at grame dot fr>