Re: [Jack-Devel] [PATCH JACK1 & JACK2] drivers/alsa/memops.c: Error when source is non-native byte-order float

PrevNext  Index
DateThu, 27 Oct 2011 01:29:19 -0700
From [hidden] at lists dot jackaudio dot org <[hidden] at lists dot jackaudio dot org
To[hidden] at free dot fr
> 
> I stole drivers/alsa/memops.c from jack1 for a project I was working on.  In doing the unit testing, I found that the code fails when the source buffer is float with non-native byte order (i.e. the sample_move_d*_sSs() functions).  The attached patch (against Jack1 SVN) fixes that.  This also affects Jack2.
> 
> As best as I can tell, these functions are only called if driver->quirk_bswap is enabled... and it's not enabled for anything as far as I can tell.  So, another valid option would be to remove this quirk and the *_sSs() functions.
> 
> -gabriel
> 
> <0001-memops-non-native-float-src.patch>


Hi Gabriel,

I recently committed your patch (adapted to JACK2) hoping it would solve the issue one guy had here with a pure float audio card, but:

1) it did not solve this specific issue

2) it seems that the patch breaks ALSA driver with some cards: see http://trac.jackaudio.org/ticket/243

Can you possibly check the patch I did at http://trac.jackaudio.org/changeset/4541 (maybe I did something wrong)

Otherwise I'll have to revert it...

Thanks

Stéphane 
PrevNext  Index

1319704247.8291_0.ltw:2,a <mailman.200311.1319704159.24103.jack-devel-jackaudio.org at lists dot jackaudio dot org>