Re: [Jack-Devel] RFC: fix for missing port registration notifications when switching master

Le 24 avr. 2011 à 22:38, Nedko Arnaudov a écrit :

> The issue was reported in #213 (second issue/patch):
> 
> jackdbus' internal graph representation is not properly kept in sync
> with the engine's graph. In particular: ports are not properly removed
> From the connection list when a client goes away; and ports
> re-appearing after a "switch-master" are not being updated (Patch
> 2/2).
> 
> I think the proposed patch is wrong because AFAIK graph reorder is only
> for ports present upon client activation. All following port
> (un)registrations must cause the port registration callback to be
> called. The proposed changeset [1] adds notification calls in the
> Attach()/Detach() methods. The changeset is commited to a dedicated
> branch [2]. The branch is (hopefully) a short living one with a signle
> commit, so it makes sense to commit it directly to svn trunk (after
> eventually rebasing it, of the svn trunk moved).
> 
> Robin, I'd be glad if you can test & report whether my fix works for
> you.
> 
> [1] http://repo.or.cz/w/jack2.git/commitdiff/55557d1f74b6d0ca80981bad9cd646d69c896e0e
> [2] http://repo.or.cz/w/jack2.git/shortlog/refs/heads/switch-master-port-registration-notifications
> 
> -- 
> Nedko Arnaudov <GnuPG KeyID: 7862B9E45D1B58ED>


Could you possibly use JackEngine::PortRegister and JackEngine::PortUnRegister to do the same thing in one operation only?

Stéphane

1303810605.15663_0.ltw:2,a <D8B3EA3D-C330-4340-9AEE-924B7BF4F73E at grame dot fr>